Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][maint] Formal errors fixed #2907

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Mar 8, 2024

Fixed:

  1. Wrong use of using namespace std in a header file
  2. Added lacking std::forward in variadic print functions.

@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Mar 8, 2024
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.00%. Comparing base (9b8aaa6) to head (c49df40).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
+ Coverage   64.84%   65.00%   +0.16%     
==========================================
  Files         101      101              
  Lines       17520    17523       +3     
==========================================
+ Hits        11360    11390      +30     
+ Misses       6160     6133      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko merged commit 03aa5e4 into Haivision:master Mar 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants