Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fixed tests that were weirdly failing #2908

Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Mar 8, 2024

Fixed the use of the server pollid in test_reuseaddr.cpp that was a "test global variable" with weird consistency rules.

@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Mar 8, 2024
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [tests] Area: Unit tests labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.82%. Comparing base (2c3f6f9) to head (7e85f0e).
Report is 1 commits behind head on master.

Files Patch % Lines
test/test_main.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
+ Coverage   64.76%   64.82%   +0.05%     
==========================================
  Files         101      101              
  Lines       17524    17526       +2     
==========================================
+ Hits        11350    11361      +11     
+ Misses       6174     6165       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko merged commit aa69c3d into Haivision:master Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants