[core] Stats: do not count discarded packets as dropped. #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
Valid for a broadcast group member dropping existing packets from the RCV buffer because they were read from another member.
maxsharabayko
force-pushed
the
hotfix/member-rcv-drop-cnt
branch
from
d83c780
to
cea18b3
Compare
Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko
force-pushed
the
hotfix/member-rcv-drop-cnt
branch
from
e1aaeea
to
810b4d7
Compare
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
…). Valid for a broadcast group member dropping existing packets from the RCV buffer because they were read from another member. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
…). Valid for a broadcast group member dropping existing packets from the RCV buffer because they were read from another member. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko
added a commit
that referenced
this pull request
Apr 29, 2024
Valid for a broadcast group member dropping existing packets from the RCV buffer because they were read from another member. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid for a broadcast group member dropping existing packets from the RCV buffer because they were read from another member, not because they are missing. Such packets are now counted as 'discarded', and not included in the 'dropped' counter.
Fixes #2879.
Closes #2882.