[core] Minor internal logging format changes. #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed CUDT::m_bTsbPdAckWakeup. Added some function to the CRcvBuffer.
maxsharabayko
added
Type: Maintenance
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
Also renamed CUDT::m_bTsbPdAckWakeup. Added some function to the CRcvBuffer. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
Also renamed CUDT::m_bTsbPdAckWakeup. Added some function to the CRcvBuffer. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
maxsharabayko
added a commit
that referenced
this pull request
Apr 29, 2024
Also renamed CUDT::m_bTsbPdAckWakeup. Added some function to the CRcvBuffer. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted changes from #2527 that don't touch the logic and thus can be safely merged. Having them merged would reduce the reviewing scope of PR #2527. Also there might be follow up changes to the TSBPD logic partially correlated with #2527, so I would like to avoid merge conflicts as much as possible.
CUDT::m_bTsbPdAckWakeuptom_bTsbPdNeedsWakeup. There is no need to wait for an ACK to be sent as it does no longer change the read-ready state.CRcvBuffer.