[core] Improved mutex protection of the TSBPD. #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
|
@jlsantiago0 could you please test with tsan? My test with xtransmit and |
ethouris
reviewed
Oct 8, 2024
|
Reproduced with xtransmit using two concurrent streams. Current PR resolves the issue (no warnings from TSAN). srt-xtransmit receive "srt://:4200" -v --enable-metrics --concurrent-streams 2 --maxconns 2
srt-xtransmit generate "srt://ip:4200" --sendrate 70Mbps --enable-metrics -v --duration 25s --concurrent-streams 2 --maxconns 2 |
Yes. |
|
@maxsharabayko I tested with 1.5.4.rc2 and the race issues and memory access violations are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased mutex protection of the TSBPDTime class, switched from a regular mutex to a shared mutex.
Fixes #3036, #3037.