Fixed bug when crafting HS response after received waveahand version 4 #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following problems are solved:
CUDT::createSrtHandshake, called from withinCUDT::updateConnStatuswhen a new handshake packet comes in, did not made itself aware yet that the peer is HSv4. The recognition is added and for that case it is made sure that the handshake is crafted exclusively according to the HSv4 rules, that is:UDT_DGRAM), not a bit flag combination used for HSv5.CONN_REJECTcase, which still is possible for various circumstances in which this function is being calledm_ConnResfield should be rather always filled by the incoming handshake andm_ConnReqby the handshake that is prepared to be send to the peer. This is currently not done in case of blocking-mode caller. This is not fixed as this doesn't change anything in the functionality, only may make the code more consistent.