Update receiver bandwidth print to respect pf:json #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndi
reviewed
May 31, 2018
apps/transmitmedia.cpp
Outdated
| @@ -161,6 +161,19 @@ void PrintSrtStats(int sid, const PerfMonType& mon) | |||
| cerr << output.str() << std::flush; | |||
| } | |||
|
|
|||
| void PrintSrtBandwidth(double mbpsBandwidth) | |||
There was a problem hiding this comment.
Please make PrintSrtBandwidth() static
There was a problem hiding this comment.
I've added the static modifier. Should I do the same for PrintSrtStats? That's what I modeled this after...
There was a problem hiding this comment.
Thanks for pointing that out @boushley! I took the liberty of making the change directly on your branch since I was already looking.
The receiver mode in stransmit did not respect the json print format request.
boushley
force-pushed
the
fix-json-printing
branch
from
83fd84d to
25e1ed9
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receiver mode in stransmit did not respect the json print format
request.