Tests: strict encription tests for blocking mode #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Priority: Low
Type: Enhancement
To be used for both blocking and non-blocking modes.
maxsharabayko
force-pushed
the
tests/strict_encription_blocking
branch
from
83426dd to
1cdccef
Compare
ethouris
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for strict encryption behavior now check both non-blocking and blocking modes.
For this case the C++11 support is now required by the testing module, so the corresponding check is added to the
CMakeLists.txt.One concern is that for blocking mode there are two sleeps (
50 ms) before checking the status of the accepted socket, because in several test cases (e.g. B2-B4) the state will be changed fromSRTS_CONNECTEDtoSRTS_BROCKENwhen the listener processes the KM response from the caller.