Fixed compilation errors when SRT is configured with --disable-logging option (#616) #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtomilov
changed the title
maxsharabayko
added
[core]
|
Fixes #616 |
srtcore/common.cpp
Outdated
| #endif | ||
|
|
||
| } // (end namespace srt_logging) |
There was a problem hiding this comment.
I am thinking if it is better to move #if ENABLE_LOGGING to line 841 instead (right above the namespace declaration).
There was a problem hiding this comment.
Right. I think it's better to move the #if ENABLE_LOGGING up to the place before namespace srt_logging starts. None of these are required when logging is not enabled.
…_logging namespace)
maxsharabayko
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.