Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MONOTONIC clock to set Garbage Collector pthread_cond_timedwait. #733

Merged
merged 10 commits into from
Aug 28, 2019
Merged

Use MONOTONIC clock to set Garbage Collector pthread_cond_timedwait. #733

merged 10 commits into from
Aug 28, 2019

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jun 13, 2019 •
edited by maxsharabayko
Loading

Fixes #729.
Closes #732.

@ethouris ethouris mentioned this pull request Jun 13, 2019
Closed
@ethouris
Copy link
Collaborator Author

Replaces #732

@ethouris ethouris added this to the v.1.3.4 milestone Jun 18, 2019
@ethouris ethouris added [core] Area: Changes in SRT library core Priority: Medium Status: Review Needed Type: Maintenance Work required to maintain or clean up the code labels Jun 18, 2019
maxsharabayko
maxsharabayko requested changes Jun 24, 2019
View reviewed changes
@maxsharabayko maxsharabayko mentioned this pull request Aug 7, 2019
Closed
13 tasks
@maxsharabayko
Copy link
Collaborator

According to the clock_gettime man page, it was necessary to link with librt for glibc versions before 2.17. Later versions include it into libc.

Examples of detecting glib version, found by @rndi

maxsharabayko
maxsharabayko approved these changes Aug 8, 2019
View reviewed changes
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monotonic clock detection to be done in #800

@maxsharabayko maxsharabayko mentioned this pull request Aug 8, 2019
Closed
maxsharabayko
maxsharabayko requested changes Aug 8, 2019
View reviewed changes
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or #806?

@maxsharabayko maxsharabayko modified the milestones: v1.3.4, v1.4.0 Aug 19, 2019
rndi
rndi suggested changes Aug 26, 2019
View reviewed changes
Copy link
Collaborator

@rndi rndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description of the new option to configure --help

@rndi rndi merged commit 2dcbacb into Haivision:master Aug 28, 2019
@maxsharabayko maxsharabayko mentioned this pull request Oct 24, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndi rndi rndi requested changes

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Priority: Medium Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Garbage Collector thread can block forever if system time is set back
3 participants
@ethouris @maxsharabayko @rndi