Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{EPOLL} New API functions #872

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Conversation

ethouris
Copy link
Collaborator

A new waiting function is introduced which differs to the current waiting function by that:
a) It reports ready socket through a single array of structure type, which contains the socket and its ready events
b) It can only work with SRT socket subscribed
c) It reports timeout by returning 0

API entry: srt_epoll_uwait.

A new flag is introduced SRT_EPOLL_ET, which makes the currently subscribed events "edge-triggered". The traditional value synchro with Linux epoll flags is preserved.

@ethouris ethouris requested a review from rndi September 12, 2019 13:14
@ethouris ethouris added [core] Area: Changes in SRT library core Priority: High Status: Review Needed Type: Enhancement Indicates new feature requests labels Sep 12, 2019
@ethouris ethouris added this to the v1.4.0 milestone Sep 12, 2019
srtcore/epoll.h Outdated
/// @param [out] fdsSet array of user socket events (SRT_EPOLL_IN | SRT_EPOLL_OUT | SRT_EPOLL_ERR).
/// @param [int] fdsSize of fds array
/// @param [in] msTimeOut timeout threshold, in milliseconds.
/// @param [bool] edgeMode if true the events returned in fdsSet are then erased
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 'edgeMode' parameter in the current version of the function

@rndi rndi merged commit 808a1fe into Haivision:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: High Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants