Fixed C deprecated enum support. Added C++03 support for examples #997
Conversation
srtcore/srt.h
Outdated
|
|
||
| #else | ||
| #define SRT_NO_DEPRECATED_ENUM | ||
| #define SRT_DECLARE_DEPRECATED_OPT(name, value) \ |
There was a problem hiding this comment.
This does not look right: no deprecated values will be defined. Also I think we still want to have enum SRT_SOCKOPT_DEPRECATED {} for C compatibility.
There was a problem hiding this comment.
Ok, I've rewritten it completely. Tested with an old compiler in C, C++ and C++11 modes. Reports the misused deprecated option perfectly in all cases.
There was a problem hiding this comment.
With gcc 4.4.1 deprecated option is not reported. Instead, I get
warning: 'SRT_SOCKOPT_DEPRECATED' is deprecated
There was a problem hiding this comment.
Intended is that you get a warning when this option is used, no matter what the warning says. If it works this way, that's good enough. I checked 4.4.1 and it reports exactly the line where the deprecated enum is used - even though the message isn't too readable.
No description provided.