Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reclassify owl:Thing -> owl:NamedIndividual #94

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jmkeil
Copy link
Contributor

@jmkeil jmkeil commented Oct 19, 2023

This PR reclassifies some resources from owl:Thing to owl:NamedIndividual.

This has no effect from the domain perspective, but fixes the following violations of the OWL 2 RL profile (see #79):

Use of non-superclass expression in position that requires a superclass expression: owl:Thing [ClassAssertion(owl:Thing <http://www.ontology-of-units-of-measure.org/resource/om-2/_9192631770PeriodsOfTheRadiationCorrespondingToTheTransitionBetweenTheTwoHyperfineLevelsOfTheGroundStateOfTheCesium133Atom>) in OntologyID(OntologyIRI(<http://www.ontology-of-units-of-measure.org/resource/om-2>) VersionIRI(<null>))]
Use of non-superclass expression in position that requires a superclass expression: owl:Thing [ClassAssertion(owl:Thing <http://www.ontology-of-units-of-measure.org/resource/om-2/internationalPrototypeOfTheKilogram>) in OntologyID(OntologyIRI(<http://www.ontology-of-units-of-measure.org/resource/om-2>) VersionIRI(<null>))]
Use of non-superclass expression in position that requires a superclass expression: owl:Thing [ClassAssertion(owl:Thing <http://www.ontology-of-units-of-measure.org/resource/om-2/oneBinaryDigit>) in OntologyID(OntologyIRI(<http://www.ontology-of-units-of-measure.org/resource/om-2>) VersionIRI(<null>))]
Use of non-superclass expression in position that requires a superclass expression: owl:Thing [ClassAssertion(owl:Thing <http://www.ontology-of-units-of-measure.org/resource/om-2/pathTravelledByLightInVacuumDuringATimeIntervalOf1299792458OfASecond>) in OntologyID(OntologyIRI(<http://www.ontology-of-units-of-measure.org/resource/om-2>) VersionIRI(<null>))]
Use of non-superclass expression in position that requires a superclass expression: owl:Thing [ClassAssertion(owl:Thing <http://www.ontology-of-units-of-measure.org/resource/om-2/systemThatContainsAsManyElementaryEntitiesAsThereAreAtomsIn0.012KilogramOfCarbon12>) in OntologyID(OntologyIRI(<http://www.ontology-of-units-of-measure.org/resource/om-2>) VersionIRI(<null>))]
Use of non-superclass expression in position that requires a superclass expression: owl:Thing [ClassAssertion(owl:Thing <http://www.ontology-of-units-of-measure.org/resource/om-2/triplePointOfWater>) in OntologyID(OntologyIRI(<http://www.ontology-of-units-of-measure.org/resource/om-2>) VersionIRI(<null>))]

@jmkeil
Copy link
Contributor Author

jmkeil commented Nov 28, 2023

@HajoRijgersberg: Do you have any concerns regarding this PR?

@HajoRijgersberg
Copy link
Owner

My apologies, Jan Martin, last month has been crazy with many, many projects, deadlines, etc. And I became a father again from a lovely daughter <3, Aurora; she and her mother are doing very fine, but Aurora came two weeks earlier than originally expected, as a result of which I got in trouble with exchanging tasks including leading tasks in the aforementioned projects. I come back to your messages and actions as soon as possible, I expect within a range of a few days till a few weeks. Hope that is Ok with you! Thank you so much for all your actions so far, and understanding in advance! ;)

@jmkeil
Copy link
Contributor Author

jmkeil commented Nov 30, 2023

Congratulations and all the best to all of you. Be assured you have my full understanding.

@HajoRijgersberg
Copy link
Owner

Thanx Jan Martin, I really appreciate that!

@HajoRijgersberg
Copy link
Owner

Hey, I would like to merge this PR, but as an experiment (for me anyway) I would like to change the version number and date in the file. Before I would do that, I would like to reflect this with you, also so that you would not be surprised by it. Looking forward to your response. Many thanx again in advance!

@jmkeil jmkeil marked this pull request as draft January 16, 2024 08:08
@jmkeil jmkeil marked this pull request as ready for review January 16, 2024 08:10
@jmkeil
Copy link
Contributor Author

jmkeil commented Jan 16, 2024

Sure. Just try it.

@HajoRijgersberg HajoRijgersberg merged commit c064eeb into HajoRijgersberg:master Feb 8, 2024
1 check failed
@HajoRijgersberg
Copy link
Owner

It worked, thanx for all your effort, help and patience, and I'll dive in your other posts soon!

@jmkeil
Copy link
Contributor Author

jmkeil commented Feb 8, 2024

Thank you for merging.

@jmkeil jmkeil deleted the noTypeOwlThing branch February 8, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants