Skip to content

Commit

Permalink
feat: Change default nodejs runtime to 18 (#145)
Browse files Browse the repository at this point in the history
  • Loading branch information
HalfdanJ authored Jan 1, 2024
1 parent 98c1e72 commit 7bacc4c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ adapter({
// These modules will be fetched when the application is deployed
dependencies: [],

// Set the Node.js version for the App Engine runtime (default: `16`)
// Set the Node.js version for the App Engine runtime (default: `18`)
// See available runtimes: https://cloud.google.com/appengine/docs/standard/nodejs/runtime
nodejsRuntime: 16,
nodejsRuntime: 18,
});
```

Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type AdapterOptions = {
/** Dependencies to be added in package.json */
dependencies?: Record<string, string>;
/**
* Nodejs version to target, defaults to 16
* Nodejs version to target, defaults to 18
* Available runtimes can be seen here:
* https://cloud.google.com/appengine/docs/standard/nodejs/runtime
*/
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const files = fileURLToPath(new URL('files', import.meta.url));

/** @type {import('.').default} **/
export default function entrypoint(options = {}) {
const {out = 'build', external = [], useCloudLogging = false, useCloudTracing = false, dependencies = {}, nodejsRuntime = 16} = options;
const {out = 'build', external = [], useCloudLogging = false, useCloudTracing = false, dependencies = {}, nodejsRuntime = 18} = options;

return {
name: 'svelte-adapter-appengine',
Expand Down
2 changes: 1 addition & 1 deletion tests/expected_app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ handlers:
- url: /.*
secure: always
script: auto
runtime: nodejs16
runtime: nodejs18
entrypoint: node index.js
default_expiration: 0h

0 comments on commit 7bacc4c

Please sign in to comment.