Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change default nodejs runtime to 18 #145

Merged
merged 2 commits into from
Jan 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ adapter({
// These modules will be fetched when the application is deployed
dependencies: [],

// Set the Node.js version for the App Engine runtime (default: `16`)
// Set the Node.js version for the App Engine runtime (default: `18`)
// See available runtimes: https://cloud.google.com/appengine/docs/standard/nodejs/runtime
nodejsRuntime: 16,
nodejsRuntime: 18,
});
```

Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type AdapterOptions = {
/** Dependencies to be added in package.json */
dependencies?: Record<string, string>;
/**
* Nodejs version to target, defaults to 16
* Nodejs version to target, defaults to 18
* Available runtimes can be seen here:
* https://cloud.google.com/appengine/docs/standard/nodejs/runtime
*/
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const files = fileURLToPath(new URL('files', import.meta.url));

/** @type {import('.').default} **/
export default function entrypoint(options = {}) {
const {out = 'build', external = [], useCloudLogging = false, useCloudTracing = false, dependencies = {}, nodejsRuntime = 16} = options;
const {out = 'build', external = [], useCloudLogging = false, useCloudTracing = false, dependencies = {}, nodejsRuntime = 18} = options;

return {
name: 'svelte-adapter-appengine',
Expand Down
2 changes: 1 addition & 1 deletion tests/expected_app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ handlers:
- url: /.*
secure: always
script: auto
runtime: nodejs16
runtime: nodejs18
entrypoint: node index.js
default_expiration: 0h
Loading