Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #11834 #1

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix for issue #11834 #1

merged 1 commit into from
Dec 10, 2023

Conversation

HananArgov
Copy link
Owner

Proposed changes

This is a fix for issue webdriverio#11834.
This will enable skipping tests from beforeTest hook in config file. just like webdriverio#11158 did for Mocha

the result is that the test is skipped:
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

this is an implementation based on a previous one for Mocha: (webdriverio#11158)

Reviewers: @webdriverio/project-committers

@HananArgov HananArgov merged commit db907f4 into master Dec 10, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant