Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed casting problems in ExecuteUtils breaking EnumerableHelpers #88

Conversation

HenrikHoyer
Copy link
Contributor

  • Average, Min, Max and Sum functions in EnumerableHelpers was broken due to casting bug in ExecuteUtils
  • Improved error messages
  • Added Tests using these methods

…nd Sum functions in EnumerationHelpers

- Improved error messages
- Added Tests using these methods
@HenrikHoyer HenrikHoyer reopened this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.27%. Comparing base (2afe410) to head (e50ff49).

Files Patch % Lines
src/Handlebars.Net.Helpers/Utils/ExecuteUtils.cs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   46.29%   47.27%   +0.97%     
==========================================
  Files          44       44              
  Lines        2912     2913       +1     
  Branches      410      411       +1     
==========================================
+ Hits         1348     1377      +29     
+ Misses       1440     1412      -28     
  Partials      124      124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixed typos in error messages
@StefH
Copy link
Collaborator

StefH commented Mar 12, 2024

@HenrikHoyer

  1. You can mark the comment comments which are fixed as "resolve conversation", this makes it easier to see which one are resolved or still open.

  2. There is a unit-test error:
    Expected result to be 450.6, but found 450.60000038146973.
    Use something like this code:
    result.Should().BeApproximately(450.6, 0.0001);

@HenrikHoyer HenrikHoyer requested a review from StefH March 12, 2024 15:58
@StefH StefH added the bug Something isn't working label Mar 12, 2024
@StefH StefH merged commit bf3cb8e into Handlebars-Net:master Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants