Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow zero values until cloud data catches up, etc. changed rounding to 3 for Watts for low readings #336

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mcc05
Copy link

@mcc05 mcc05 commented Apr 22, 2023

Description

Changes to allow zero values until cloud data catches up, etc. changed rounding to 3 for Watts for low readings, changed cost to TOTAL in HA instead of TOTOALINCREASING and handle only getting the latest cost.

How Has This Been Tested?

Ran the code for last 2 days and works as expected.

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)

Stopped returning "unknown" value for sensor where the return from the API is zero value of usage, i.e. running of solar and all entries are valid zero's, also helps with the delay in getting gas readings.
Changes Cost sensor state class to TOTAL to remove HA warning about monetary value
added int check also
Corrected for adding costs up now not total increasing, my bad
Updated to fix cost to be latest
Tested changes, allow for zero returns for consumption, round to 3 places instead of two for Watts, make cost total and not increasing for HA and only get latest cost
@mcc05
Copy link
Author

mcc05 commented Apr 22, 2023

Please consider these changes

Trap error if valid cost data not returned
return zero if expection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant