Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add japanese language support #1093

Merged
merged 5 commits into from
Mar 27, 2022

Conversation

musashi-miyamoto
Copy link
Contributor

This adds the japanese language translation support.

Changes

  • Adds japanese string resources (.resx)
  • Adds flag image
  • Adds japanese flag button to the demo app

Testing

I checked these controls.

  • MessageBox button text
  • ColorPicker button text
  • TimeBar interval text
  • Pagination jump button text
  • Clock AM/PM

MessageBox
ColorPicker
TimeBar
Pagination
Clock

@NaBian
Copy link
Member

NaBian commented Mar 19, 2022

awesome work! can you provide language for hc demo too? 😄

@ghost1372
Copy link
Member

awesome work! can you provide language for hc demo too? 😄

hmm... already done!
Untitled

@NaBian
Copy link
Member

NaBian commented Mar 20, 2022

awesome work! can you provide language for hc demo too? 😄

hmm... already done! Untitled

no, all in english.

@musashi-miyamoto
Copy link
Contributor Author

awesome work! can you provide language for hc demo too? 😄

hmm... already done! Untitled

no, all in english.

ok now I'm working on it, please wait a still 🏃

Control names are still English because:
- Visual Studio did not translate WPF controls in Japanese.
- Japanese accepts common English words.
Fix invalid translation.
@musashi-miyamoto
Copy link
Contributor Author

Demo-app translation done!

@NaBian NaBian merged commit 87c5285 into HandyOrg:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants