Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MenuItemAttach. #647

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Add MenuItemAttach. #647

merged 3 commits into from
Sep 28, 2023

Conversation

GF-Huang
Copy link
Member

Features:

  • Make menu items of the same level and the same group name work like radio buttons.
  • Disable the checkable menu item to uncheck itself if it is already checked.

Example:

image

JVag7sfPIr

@GF-Huang GF-Huang requested review from NaBian and ghost1372 January 25, 2021 18:39
ghost1372
ghost1372 suggested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@ghost1372 ghost1372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn't we be able to uncheck the item?

src/Shared/HandyControl_Shared/Controls/Attach/MenuItemAttach.cs Outdated Show resolved Hide resolved
@ghost1372 ghost1372 mentioned this pull request Feb 26, 2021
Open
@ghost1372 ghost1372 added the 🏭 enhancement New feature or request label Dec 18, 2021
@NaBian NaBian merged commit ebf59d2 into HandyOrg:master Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghost1372 ghost1372 ghost1372 approved these changes

@NaBian NaBian Awaiting requested review from NaBian

Assignees

@GF-Huang GF-Huang

Labels
🏭 enhancement New feature or request
Projects
HandyControl Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GF-Huang @ghost1372 @NaBian