Fix VisibilityRequiredVoter version branch

HangarMC · Sep 30, 2023 · 35b2163 · 35b2163
1 parent c8d381e
commit 35b2163
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/.../main/java/io/papermc/hangar/security/annotations/visibility/VisibilityRequiredVoter.java b/.../main/java/io/papermc/hangar/security/annotations/visibility/VisibilityRequiredVoter.java
@@ -41,19 +41,19 @@ public int vote(final Authentication authentication, final MethodInvocation meth
                     } else if (this.projectService.getProjectTable((long) arguments[0]) != null) {
                         return ACCESS_GRANTED;
                     }
-                } else {
-                    return ACCESS_DENIED;
                 }
+                return ACCESS_DENIED;
             case VERSION:
-                if (arguments.length == 1 && this.versionService.getProjectVersionTable((long) arguments[0]) != null) {
-                    return ACCESS_GRANTED;
+                if (arguments.length == 1) {
+                    if (this.versionService.getProjectVersionTable((long) arguments[0]) != null) {
+                        return ACCESS_GRANTED;
+                    }
                 } else if (arguments.length == 3) {
                     if (this.versionService.getProjectVersionTable((String) arguments[0], (String) arguments[1]) != null) { // TODO is platform needed here?
                         return ACCESS_GRANTED;
-                    } else {
-                        return ACCESS_DENIED;
                     }
                 }
+                return ACCESS_DENIED;
         }
         return ACCESS_ABSTAIN;
     }