Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grazie grammar checking strategy #1196

Merged

Conversation

fberlakovich
Copy link
Contributor

@fberlakovich fberlakovich commented Jan 22, 2020

Fixes #1153

Additions

Changes

Fix Grazie strategy to detect issues also at the beginning of a sentence #1153
Fix CompileGutter to return linemarker info only for leaf elements (Use the begin document text leaf element). This fix removes a runtime error log message and allows the Grazie grammar strategy tests to succeed

Backwards incompatible changes

Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah the log is full of LineMarker is supposed to be registered for leaf elements only warnings, but unfortunately I didn't manage to fix that. I still get these warnings for \documentclass and \usepackage for example, do you perhaps have any idea how to fix those? I'm not sure exactly how it works, but I think they are not leaf elements while we still want a line marker for them.

btw perhaps it's an idea to fix your email in your .gitconfig and/or add it to github to get your commits attributed

@fberlakovich
Copy link
Contributor Author

Thanks! Yeah the log is full of LineMarker is supposed to be registered for leaf elements only warnings, but unfortunately I didn't manage to fix that. I still get these warnings for \documentclass and \usepackage for example, do you perhaps have any idea how to fix those? I'm not sure exactly how it works, but I think they are not leaf elements while we still want a line marker for them.

I guess the warnings stem from the other two linemarker contributors. I do know how they work now and should be able to fix them. Would you mind creating a bug for it (I am at the office currently and don't have access to a TeXiFy IDE)?.

btw perhaps it's an idea to fix your email in your .gitconfig and/or add it to github to get your commits attributed

Thanks, I completely missed it!

@PHPirates PHPirates merged commit 82d0af8 into Hannah-Sten:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grazie support misses mistakes in text
2 participants