Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up LatexInclusionLoopInspection #1327

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Speed up LatexInclusionLoopInspection #1327

merged 2 commits into from
Apr 2, 2020

Conversation

PHPirates
Copy link
Collaborator

Summary of additions and changes

  • Instead of using DFS on all file inclusions in the project, loop over commands index once and try to find file inclusion loops. Unfortunately this means we can only detect loops involving two files, but the old way was really hurting performance too much relative to the importance of the inspection (delayed all inspections for 20s in a large project for me).

How to test this pull request

  • Two files that include each other, inspection only shown on one of them

Wiki

  • Updated the wiki

@PHPirates PHPirates added this to the b0.6.10 milestone Mar 30, 2020
@PHPirates PHPirates self-assigned this Mar 30, 2020
@PHPirates PHPirates merged commit 10c0638 into master Apr 2, 2020
@PHPirates PHPirates deleted the caching branch April 2, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slideclimb slideclimb slideclimb approved these changes

@HannahSchellekens HannahSchellekens Awaiting requested review from HannahSchellekens

@stenwessel stenwessel Awaiting requested review from stenwessel

Assignees

@PHPirates PHPirates

Labels
None yet
Projects
None yet
Milestone
b0.6.10
Development

Successfully merging this pull request may close these issues.
2 participants
@PHPirates @slideclimb