Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional parameters parsing for \newcommand #1453

Merged
merged 4 commits into from
Jun 7, 2020
Merged

Conversation

PHPirates
Copy link
Collaborator

Summary of additions and changes

  • Fix optional parameters parsing when first parameter for new command is optional

How to test this pull request

    \newcommand{\test}[2][1]{hi}
    \newcommand{\lvec}[2][n]{\ensuremath{#2_1+\cdots + #2_{#1}}}
    For the series \lvec{x} we have \[ \lvec{x} = \sum_{k=1}^{n} G_{\lvec[k]{y}} \]
    \test{asfd}{asdf}
    \lvec{}{} % still wrong: first param should be optional. may be fixed in a different branch

@PHPirates PHPirates added this to the ? milestone Jun 6, 2020
@PHPirates PHPirates merged commit 3ba1a73 into master Jun 7, 2020
@PHPirates PHPirates deleted the brace-pairs branch June 7, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant