-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert Graphic wizard and image Drag and Drop #1729
Conversation
- Added CustomFileDropHandler. - Added utils for extracting files from transferables. - Added graphic file extensions magic constant.
…g absolute file path into a relative one.
…ters, also fixed the relativize functionality and put it into a seperate util for later use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
One other thing, not about this PR, but while we're talking UI: the 'insert table' dialog is not really usable for me, because it's not really scaling well and somehow is much too small. I can't rescale it manually, I think.
Do you know how to fix that? (Not necessarily for this PR, but I looked at it a while ago and couldn't find an easy solution)
You can set a minimumSize and preferredSize, might help |
Summary of additions and changes
Edit > LaTeX
menu.\includegraphics
supported file type will open the Insert Graphic wizard with the dropped file path inserted as image.graphicx
orfloat
(if necessary).How to test this pull request
Just drag and drop a by
\includegraphics
supported file, or select one using the menu option. Follow the options.Wiki
Pictures
The wizard UI:
Slightly changed edit menu:
Demo:
include-graphics-demo.mp4