Support multiple MiKTeX installations in MiktexSDK, bstinputs, texcount and command redefinitions #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPirates
requested review from
HannahSchellekens,
slideclimb and
stenwessel
as code owners
| results.add(path.substring(0, index)) | ||
| val paths = "where pdflatex".runCommand() | ||
| if (paths != null) { | ||
| paths.split("\r\n").forEach { path -> |
There was a problem hiding this comment.
would System.lineSeparator() be better?
There was a problem hiding this comment.
In theory, yes, but for MikTeX on Linux/Mac the pdflatex executable will not be present in that directory anyway - which is a separate problem I need to look into. When I do so, I might rename this one to WindowsMiktexSdk.
PHPirates
changed the title
PHPirates
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TEX-93
Fix #1757
Fix #1723
Fix #1753
Fix #1765 (well, workaround)
Summary of additions and changes
I think the bug is already in 0.7.3, but I assume it can only happen if you have multiple MiKTeX installs.