-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use safe delete in deletion quick fixes #1787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPirates
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've had this before, where a UI element takes the psi element class name instead of human readable name, will try to find how to change that.
PHPirates
requested changes
Feb 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # build.gradle.kts # gen/nl/hannahsten/texifyidea/parser/LatexParser.java # src/nl/hannahsten/texifyidea/inspections/bibtex/BibtexUnusedEntryInspection.kt # src/nl/hannahsten/texifyidea/inspections/latex/LatexFigureNotReferencedInspection.kt
PHPirates
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TEX-16
Summary of additions and changes
Known bug The text in the safe delete dialog is a bit weird and there doesn't seem to be a way to customise it.
How to test this pull request
Example of safe delete finding a usage in a comment:
![safe-delete-bib-ref](https://user-images.githubusercontent.com/15685876/109385845-f903dd00-78f6-11eb-9b5f-436a61b6c8dc.png)
Wiki