BINDINGS/C++: Don't expose codec info path in C++

HappySeaFox · Mar 19, 2021 · 20dff53 · 20dff53
1 parent 86bc6e8
commit 20dff53
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 19 deletions.
diff --git a/src/bindings/c++/codec_info-c++.cpp b/src/bindings/c++/codec_info-c++.cpp
@@ -39,7 +39,6 @@ class SAIL_HIDDEN codec_info::pimpl
 
     const sail_codec_info *sail_codec_info_c;
 
-    std::string path;
     std::string version;
     std::string name;
     std::string description;
@@ -65,8 +64,7 @@ codec_info& codec_info::operator=(const codec_info &ci)
 {
     d->sail_codec_info_c = ci.d->sail_codec_info_c;
 
-    with_path(ci.path())
-        .with_version(ci.version())
+    with_version(ci.version())
         .with_name(ci.name())
         .with_description(ci.description())
         .with_magic_numbers(ci.magic_numbers())
@@ -98,11 +96,6 @@ codec_info::~codec_info()
     delete d;
 }
 
-const std::string& codec_info::path() const
-{
-    return d->path;
-}
-
 const std::string& codec_info::version() const
 {
     return d->version;
@@ -284,8 +277,7 @@ codec_info::codec_info(const sail_codec_info *ci)
         mime_type_node = mime_type_node->next;
     }
 
-    with_path(ci->path)
-        .with_version(ci->version)
+    with_version(ci->version)
         .with_name(ci->name)
         .with_description(ci->description)
         .with_magic_numbers(magic_numbers)
@@ -295,12 +287,6 @@ codec_info::codec_info(const sail_codec_info *ci)
         .with_write_features(sail::write_features(ci->write_features));
 }
 
-codec_info& codec_info::with_path(const std::string &path)
-{
-    d->path = path;
-    return *this;
-}
-
 codec_info& codec_info::with_version(const std::string &version)
 {
     d->version = version;

diff --git a/src/bindings/c++/codec_info-c++.h b/src/bindings/c++/codec_info-c++.h
@@ -64,7 +64,6 @@ class SAIL_EXPORT codec_info
     codec_info& operator=(codec_info &&ci);
     ~codec_info();
 
-    const std::string& path() const;
     const std::string& version() const;
     const std::string& name() const;
     const std::string& description() const;
@@ -183,7 +182,6 @@ class SAIL_EXPORT codec_info
      */
     explicit codec_info(const sail_codec_info *ci);
 
-    codec_info& with_path(const std::string &path);
     codec_info& with_version(const std::string &version);
     codec_info& with_name(const std::string &name);
     codec_info& with_description(const std::string &description);

diff --git a/src/libsail/codec_info.h b/src/libsail/codec_info.h
@@ -41,7 +41,7 @@ struct sail_codec_info_node;
  */
 struct sail_codec_info {
 
-    /* Full path to the codec. */
+    /* Full path to the codec. NULL when SAIL_COMBINE_CODECS is ON. */
     char *path;
 
     /*