Call to image.with_shallow_pixels will free pixels used in previous call to with_shallow_pixels

[Geof23]

The notes in image-c++.h indicate that, with this function, shallow data is not deleted upon image destruction.

It's a natural assumption that this would include reuse of the image object.

(SHA 6250cce)

[Geof23]

(suggested fix)

--- a/src/bindings/c++/image-c++.cpp
+++ b/src/bindings/c++/image-c++.cpp
@@ -303,7 +303,8 @@ image& image::with_shallow_pixels(void *pixels)

 image& image::with_shallow_pixels(void *pixels, unsigned pixels_size)
 {
-    sail_free(d->pixels);
+    if(!d->shallow_pixels)
+        sail_free(d->pixels);

     d->pixels         = nullptr;
     d->pixels_size    = 0;

[HappySeaFox]

Thanks for the report! I'll look into it.

[Geof23]

NP! Thanks Dmitry

…

On Mon, Feb 8, 2021 at 2:52 AM Dmitry Baryshev ***@***.***> wrote: Thanks for the report! I'll look into it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJOD66QJKRMCHIB6SRNSDS567AHANCNFSM4XG5ZC7A> .