This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Stop changing global dark mode setting on start #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops Slide from changing the global night mode setting on start
|
Thank you for the PR! Looks good, including this in the next update |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3065
This method is supposed to check if the "Automatic" option of dark mode is supported, but due to the setNightMode() method the setting changes globally. By removing this call the bug no longer happens and the auto check still succeeds.
Photo of "Night mode" settings dialog showing the "Automatic" option correctly:
