-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTRExporter shouldn't accept the wrong rom #10
Comments
I can't even tell what the correct rom even is. The ZeldaRET repo seems to be built with a very specific debug rom in mind or it fails whilst this repo requires a completely different debug rom or it fails; not to mention the fact that neither repo makes this clear in the instructions. |
Okay so after messing around some more, I've discovered two things. (1) The rom mentioned in the readme file specifically is asking for the "Feb, 21 2003" Gamecube (not Master Quest) debug rom. This version is preserved if you look on the website known for dumping and archiving prototypes. Loading this rom as it is into SoH's OTR generator results in a working game....until you get past the initial start of the opening cutscene where Ganondorf rides out and the audio freaks the hell out. Additionally, during OTR generation, a load of errors are thrown up, so yeah. You're obviously not meant to do that. (1.5) Nope, a regular retail rom doesn't work either. (2) The ZeldaRET compiler does not work with the above debug rom. It specifically looks for and wants the Master Quest version of the debug rom, which is completely different to the one SoH needs. Trying to use ZeldaRET with the above rom straight up fails at the "make setup" stage and it's not possible to progress further. Trying to use the rom ZeldaRET wants with SoH results in the graphical glitches in the OP happening. So I honestly have absolutely zero clue what the hell this thing actually wants to make it function properly because nothing is clear whatsoever and I sure as hell aren't going to join your Discord server to find out. Discord is not a replacement for an actual support forum, which is served here by this exact issues page. Please clarify how on earth you're meant to even use this program. |
It's the non-master quest debug version that for the PAL/Europe gamecube version. See the No Intro db entry for more info. Note that there's no download link, just a listing of hashes. |
That's even more baffling then considering that's a third alternate debug rom that isn't even referenced by this repo or ZeldaRET....Oh well, good to know which specific version it is, thank you. Will report back to see how it goes... |
Please follow the instructions in the github readme. It provides all the necessary information on the correct rom to use. |
I did, multiple times. Nothing works properly. The readme has conflicting and/or unclear information. It does not help that the readme says it needs a ZeldaRET OOT rom but then gives the crc and build code for a specific debug build that the ZeldaRET compiler does not support. And just now, the one King-of-Toasters mentioned; throwing that into OTRGui worked until it was flying by spitting out a million errors a second and again, ZeldaRET wont have it. I get that you're dancing around things a lot in an effort to not get C&D'd here but having more specific information whilst not telling anyone where to get the things needed would help a lot. |
Sigh Okay, it turns out the one matching the sha1 mentione din the readme file was the actual correct one, and that I was in fact running into issue #13 which caused the audio to freak out and made me think i did it wrong however, this rom has absolutely nothing to do with the ZeldaRET project. I dont even know why it's mentioned in the readme, because you dont need to go anywhere near it to get this running. you just need a specific debug rom. Which is especially confusing because (a) an interview piece with one of the developers of this project said that it could be used with any retail rom dumped by the user and (b) the command line for creating the OTR file spits out a crapload of errors that really dont help the vibe that i was doing something wrong. this is kind of what i was saying when i said it was unclear, y'all. |
You are mixing decomp and the port. The zeldaret compiler is not relevant here. ido is not used. No compilation necessary unless you're compiling SoH using msvc to help develop. Ignore the commandline and its errors during |
It's because the debug ROM needed for asset extraction currently was released by ZeldaRET after someone donated it to them. |
Right I see. I'm still confused as to why you can't just directly reference the specific rom in question without saying anything about where to get it though. calling it the "zret debug rom" really just makes it very confusing because searching for such a thing just brings up information about the zeldaret compiler, since that uses a debug rom itself. as i say: its not very clear what exactly is needed because theres not enough information to go off, especially as someone who has basically no knowledge of the games release history or its build info. you should probably also put in a note mentioning to ignore errors int he command line though. |
Add support for multi-bg rooms
Fixed known broken gossip stones and Dampe Gravedigging Tour Check
* Initial Auto-Location Tracking * Updates styling for checked items in Check Tracker * Fixes crashing issues with Check Tracker rendering * Auto scroll Check Tracker windows to current area * Checks Tracker only shows checked locations once in game * Fixes issue where Check Tracker would auto-scroll to wrong location when entering a grotto * Fixes gerudo fortress checks showing in tracker when settings have them removed * InfTable Check Location Fixes: Lost Dog Richard, Rolling Gorons, HBA 1000, Thawed Zora * Fixes most Event Chk Inf Checks on Check Tracker, and Frogs * Check Tracker - Song from Malon now works * Check Tracker - Fixes Claim Check check not tracking - Fixes spoiler for Claim Check check when getting Biggoron's Sword - Fixes LACS being spoiled and not tracking * Check Tracker - Fixes #2 for Skull Mask and Mask of Truth checks * Check Tracker - Adds support for merchants - Fixes #7 for Bomchu Salesman - Fixes #12 for Medigoron * Check Tracker - Fixes #8 for Song from Saria * Check Tracker - Fixes #9 for Adult Shooting Gallery * Check Tracker - Fixes #10 for Composer Grave * Check Tracker - Fixes #14 for Song from Ocarina of Time * Check Tracker - Fixes #16 for Shooting the Sun * Check Tracker - Fixes #19 for Darunia's Joy * Save Editor - Adds missing label for Treasure Chest Game * Check Tracker - Fixes Great Faries checks * Check Tracker - Fixes Sheik at Temple * Check Tracker - Fixes Great Fairy auto-scroll to wrong location * Check Tracker - Updates blue warp checks - Fixes Bongo Bongo and Twinrova checks * Check Tracker - Fixes Dampe's Gravedigging Tour * Check Tracker - Fixes Prescription to King Zora * Check Tracker - Fixes Bazaar showing under wrong area on tracker between adult/child * Check Tracker - Fixes scroll for Hyrule Market and Bazaar * Check Tracker - Fixes giving Adult Trade Items shown on tracker: Broken Sword, Saw, Cojiro, Eyeball Froge, and Eyedrops * Cleans up item_location * Check Tracker - Item List - Fixes item list not updating when changing seeds/options - Separates item exclusion list from item check list - Clean up comments * Check Tracker - Adds Skip functionality to buttons * Check Tracker - Refactors adult trade items to RandomizerInf * Check Tracker - Fixes an issue where any time an item is removed the tracker would cause an application crash * Check Tracker - Item names are now dependent on file language * Check Tracker - Fixes Gerudo Card check not showing in Fast setting * Reorders headers to (hopefully) avoid CI build conflicts on linux/consoles * Explicitly defines vector header in randomizer.h to fix compile errors * Complete Refactor of Check Tracker ImGui * Adds missing check tracker files to CMakeLists * Reverts the Item_location whitespace cleanup from ad10807 * Check Tracker - Loading Fixes - Fixes a bug where loading a save file a second time would add all the checks again - Fixes a bug where the check tracker would not render at all until in a save file * Check Tracker - Fixes a bug where checks would sometimes fail to load * Check Tracker - Fixes duplicated checks when using Only on Pause or Only on Combo * Check Tracker - Works around issue where single characters don't show in EnhancementCombobox, and fixes a label for combo buttons held option * Check Tracker - Applies all Check Tracker changes to Item Location * Check Tracker - Updated Check List - Adds Link's pocket, either in KF or HM depending on starting age - Supports Scrubs and Merchants - Uses enums instead of magic numbers - Updates DC Scrub Short Names for MQ * Check Tracker - Adds a performance mode option * Check Tracker - List Fixes (requires new rando generation) - Fixes Frogs Rupees always visible - Fixes Kokiri Sword Chest not showing - Fixes Weird Egg not showing * Check Tracker - MQ List basic support * Check Tracker - MQ/Vanilla anti-spoilers * Check Tracker - Collecting a compass now spoils the area * Check Tracker - Basic Vanilla Support and fixes - Vanilla items show in check tracker, even if many won't auto check - Fixes an issue with Gerudo Fortress Keys - Refactors IsVisibleInCheckTracker to randomizer_check_tracjer * Check Tracker - Fixes merge conflict from 08a487f * Check Tracker - Fixes tracker loading as Floating when default value is set to Windowed * Randomizer Location Exclusion List - Adds Scrubs, Merchants, Shops. Adult Trade items, MQ Dungeons, and Bean Salesman - Fixes Kokiri Sword Chest, Weird Egg, and Frog Song Rupees from misbehaving - Updates Gerudo Fortress logic to be dependent on Open/Fast/Normal Fortress - Removes Invalid Check - Adds RO Enum for MQ settings - Updates magic values to RO enum * Location Exclusion List - Scrubs that are always randomized now always show on the list * For now, removes some extra code only needed for a Check Tracker. * Randomizer Location Exclusion List - Fixes Eyeball Frog from showing up when Adult Trade Items was off * Location Tracker - Updates Eyedrops to use RandomizerInf instead of Chest * Check Tracker - Fixes a bug where Link's Pocket item wasn't acting as checked for area item count * Check Tracker - Fixes a bug where Locations would incorrectly say Vanilla due to the first check in the area being a non-MQ check * Check Tracker - Fixes a crash when Check Tracker is docked but not visible * Check Tracker - Fixes areas being spoiled when loading different save files * Check Tracker - Only reset variables if they are initialized * Check Tracker - Cleans up old comments, unused variables, methods, and macros, adds language TODOs, * Check Tracker - Readds rainbow UI elements after Cosmetics Editor refactor * Check Tracker - Removal of flag lookup that was refactored, no longer needed header, and some trivial whitespace fixes. * Check Tracker - Refactors Index to Bitmask code to a macro * Check Tracker - Changes ordering from alphabetical to RandomizerCheck ordering * Check Tracker - Wraps everything in a namespace to avoid global variable usage * Check Tracker - Explicitly defines for-loop scope * Check Tracker - refactors dungeon lookup from static array to function * Fixes a bug when using EnhancementColor with alpha * Check Tracker - Refactors all colour to use direct conversions * Check Tracker - refactors settings loading and check visibility for readability * Check Tracker - Fixes a bug where the wrong label showed on the Check Tracker BG Color * UIWidgets - Adds Alpha bar to EnhancementColor when using alpha parameter
* The mother of all commits * Removed `GI_SWORD_MASTER`; "Master Sword" Items now actually give MS * Removed dupe MS entries in item pool; updated GIMESSAGE (should stop crashing on non-Windows); re-added MS in item list * Give Adult Link a freebie with shuffle MS on; cihld -> adult no longer gives MS; ToT Master Sword now gives correct item * add master sword GI draw func based on ToT MS object * Force `MasterSword` logic var to only update upon getting MS * Dorf funny line now activates with LA and MS in inv * Apply suggestions * Updated RAND_INF; Check Tracker changes; Gave RAND_INF and ice trap logic to ToT MS check; Fixed swordless behavior for HBA/fishing * ToT MS Check now works in check tracker; Visual bug where box hovers over non-existent MS gone; Fixed RAND_INF check with ToT MS pedestal; Ganon no longer gives free MS * adult equips no longer reset in MS shuffle * Apply (most) locacc review suggestions Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com> * Reorganized swordless check for interface to fit edge cases; getting master sword no longer highlights box * Edge case for BGS but no bow * Fix implicit declaration error for GI hooks (#9) * Adjusted `CanAdultAttack/Damage`; applied logic suggestions * Fixed build errors (hopefully) * Cleanup merge * get shit working again * Tidied up remaining uses of DD flag as rando indicator * make master sword invisible and fix ms flag (#10) * Add text to sheik if go mode is obtained but barrier is still up * overhaul swordless behavior in `func_80083108` * reworked ToT MS Check to have an actual GI * suggestions * Apply suggestions * Better swordless handling with temp B (#11) * better swordless handling with temp B * prevent auto save in fishing pond * prevent auto save during bombchu bowling * enum fix --------- Co-authored-by: Adam Bird <archez39@me.com> Co-authored-by: inspectredc <78732756+inspectredc@users.noreply.github.com> Co-authored-by: RaelCappra <rael.cappra@gmail.com> Co-authored-by: Adam Bird <Archez@users.noreply.github.com>
Cleans up OTRWindow resolution inspection.
…Dump [Time Saver] Empty Bottles Faster
it should reject the wrong rom but instead allows it and we see these texture issues when playing
The text was updated successfully, but these errors were encountered: