Rumble Pack not detected but rumbling works

[V10lator]

It's basically just a cosmetic issue as rumble itself works just fine:

(this is at the fishing game at the lake)

[jbodner09]

I was looking at this in the debugger, and basically none of the places where the controller's expansion pack type is set are actually triggered, so it always thinks the controller is empty when checking what type of pack is inserted. The code to actually trigger the rumbles appears to be set regardless, so for a bug-level fix, I think all I need to do is manually tell it a rumble pack is inserted when using a non-keyboard controller. My goal today is to see if there's an appropriate place to do that (appropriate meaning some code that runs when a controller is attached that doesn't when a keyboard is).

Long-term, it might be beneficial to make the game aware of different types of input instead of just hacking everything to look like an N64 controller.

[briaguya-ai]

I think all I need to do is manually tell it a rumble pack is inserted when using a non-keyboard controller.

a config menu option for rumble could be good, if the controller doesn't support it then disable the option, but with a supported controller allow enabling/disabling rumble

Long-term, it might be beneficial to make the game aware of different types of input instead of just hacking everything to look like an N64 controller.

absolutely! @StardustSauce mentioned wanting to work on that. that could also help with #27, as well as more flexibility when configuring controls for ocarina playing etc.

[jbodner09]

a config menu option for rumble could be good

Agreed, but that should probably be in a different PR. If you don't get around to creating an issue to track that, I will!

[PurpleHato]

Re-opening this one since the issue is still technically there since the check for rumblepack isn't made properly on the fishing minigame and trigger the wrong dialog for it