Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Savers: Ask to Equip New Items #1133

Merged
merged 8 commits into from
Oct 24, 2022

Conversation

vaguerant
Copy link
Contributor

Seeks to partially address @jbodner09's #482.

When enabling this Time Saver Enhancement and obtaining a new sword, shield or tunic (either because it's brand new, previous shield was burned, tunic was eaten by a Like-Like, etc.), the "You got a [...]" message is extended to add "Would you like to equip it now?"

If the player selects yes, the equipment is immediately swapped on the fly, with appropriate sound-effect, avoiding the need to navigate to the equipment screen and manage it manually.

If the player selects no, then no.

Other notes:

  • English, French and German are supported
  • the prompt only occurs if Link is currently able to equip the item, per age-restrictions; if not, the normal "You got a [...]" message with no prompt is returned
  • uses the new custom message implementation to handle the control codes and special international characters like é in French, etc.
  • tested working with equipment from chests, the ground, Deku Salesmen, Medigoron, Biggoron and regular shops

@vaguerant vaguerant marked this pull request as draft August 10, 2022 11:21
@aMannus
Copy link
Contributor

aMannus commented Aug 10, 2022

Could you add this to the new enhancement presets as well? So both setting the cvar to 0 in the default one, and then add it to whatever preset you think fits best. I'd personally vote for the Enhanced preset for this one.

@vaguerant vaguerant marked this pull request as ready for review August 11, 2022 08:48
@vaguerant
Copy link
Contributor Author

vaguerant commented Aug 11, 2022

Added to the presets as suggested, off in Default and on in Enhanced.

Re: The buildbot failure, running theory is something is up on the bot's end. The autobuild failed to create the Linux appimage, and two subsequent manually triggered builds timed out without ever starting while waiting for the Mac build machine to become available. Same seems to have happened to #1160.

EDIT: Buildbot's happy again.

@dcvz dcvz requested a review from briaguya-ai October 23, 2022 09:10
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once merge conflicts are resolved let's :shipit:

@vaguerant
Copy link
Contributor Author

Conflicts resolved. 👍

@briaguya-ai briaguya-ai merged commit 67e98d4 into HarbourMasters:develop Oct 24, 2022
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Time Savers: Ask to Equip New Items

* Add to presets; fix early SFX

* Simplify text reading

* Shrug, does this fix it

* Merge error

* Merge develop
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Time Savers: Ask to Equip New Items

* Add to presets; fix early SFX

* Simplify text reading

* Shrug, does this fix it

* Merge error

* Merge develop
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Time Savers: Ask to Equip New Items

* Add to presets; fix early SFX

* Simplify text reading

* Shrug, does this fix it

* Merge error

* Merge develop
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
* Time Savers: Ask to Equip New Items

* Add to presets; fix early SFX

* Simplify text reading

* Shrug, does this fix it

* Merge error

* Merge develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants