Graphics backend enhancements etc. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiritoDv
suggested changes
Apr 13, 2022
| @@ -256,29 +248,29 @@ namespace SohImGui { | |||
| } | |||
| } | |||
|
|
|||
| void Draw() { | |||
|
|
|||
| void Draw1() { | |||
There was a problem hiding this comment.
I think you should change this to something more recognizable like RenderMenu and RenderFramebuffer for Draw2
| @@ -1007,7 +1007,7 @@ bool ImGui::ScrollbarEx(const ImRect& bb_frame, ImGuiID id, ImGuiAxis axis, ImS6 | |||
| return held; | |||
| } | |||
|
|
|||
| void ImGui::ImageRotated(ImTextureID tex_id, ImVec2 center, ImVec2 size, float angle) { | |||
| void ImGui::ImageSimple(ImTextureID tex_id, ImVec2 center, ImVec2 size) { | |||
There was a problem hiding this comment.
Remove this function and change it to ImGui::Image
| ImGui::Text("Internal Resolution:"); | ||
| ImGui::SliderInt("Mul", reinterpret_cast<int*>(&gfx_current_dimensions.internal_mul), 1, 8); | ||
| } | ||
| ImGui::Text("Internal Resolution:"); |
There was a problem hiding this comment.
This was my fault, but it would be cool if you move this into a Graphics category on the menubar
Kenix3
approved these changes
Apr 17, 2022
PurpleHato
pushed a commit
to PurpleHato/Shipwright
that referenced
this pull request
Jun 23, 2022
…hest-fix dc boss room chest fix
Kenix3
pushed a commit
to Kenix3/Shipwright
that referenced
this pull request
Oct 19, 2022
Malkierian
pushed a commit
to Malkierian/Shipwright
that referenced
this pull request
Nov 20, 2023
Malkierian
pushed a commit
to Malkierian/Shipwright
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies and unifies how the framebuffers concept is implemented in the different gfx backends.
This allows SSAA, MSAA and N64 mode to be implemented by both the OpenGL and Direct3D 11 backends in the same way. The ImGUI gui has been updated accordingly.
When rendering for unscaled resolution, the OpenGL renderer now renders directly to the back buffer instead of to a texture which is then rendered to the back buffer, in order to save some performance.
The glClipControl usage is now removed and the y flipping has been moved to software. This should only result in a tiny performance decrease but will allow framebuffers to not be rendered upside-down on old hardware/drivers. It should also remove the need to use GLEW on Linux.
Another huge improvement that drastically reduces CPU% and GPU% in Kokiri forest is the batching of all read depth value calls to a single one, to avoid ping-ponging the GPU for every pixel that should be read (11 in Kokiri Forest and 26 in that grotto outside Shadow Temple). The OpenGL renderer now also avoids a read pixel "slow path" when the Intel driver was used that made it slower at higher resolutions.
I also moved audio to a separate thread, so it can be parallelized with the gfx rendering. It's still synchronized to the game though so the audio thread never does any job while the game logic runs. This also avoids the audio to drift in case the game or graphics would lag, which might be important in cutscenes.