Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to lock a cosmetic from being randomized #1812

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

lilacLunatic
Copy link
Contributor

Resolves #1809

@briaguya-ai
Copy link
Contributor

any chance you could add some screenshots? the code is looking good, just want to make sure everything looks good in the ui. also, i'd want to see how this looks on wii u and switch (since they have some slight differences in imgui rendering)

@lilacLunatic
Copy link
Contributor Author

I've made a short video which I also uploaded on Discord. Let me know if screenshots are needed too. I can't show what it looks like on other platforms, someone with the hardware will have to test that.
https://user-images.githubusercontent.com/8488221/196988034-a84d8bc1-51cf-413b-97a9-87d2fdaf7b0f.mp4

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still hasn't been tested on switch/wii u but i don't expect it to be an issue there. if it is, we can make handle that in a followup pr

:shipit:

@briaguya-ai briaguya-ai merged commit af02623 into HarbourMasters:develop Oct 21, 2022
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a toggle to lock cosmetic option from being randomized
2 participants