[Bugfix] Add check for animation count to prevent continuing final saw textbox while putaway is happening #3103
Conversation
… while putaway is happening.
|
Nice find! The solution is rather simple and self contained, I like it. My only question is, with this technically being a authentic vanilla bug (that is exasperated due to Skip Text) and the fix is to alter the actor, should we consider wrapping this as a "fix toggle" in the menu? Maybe add it to the rando preset, or just apply the fix always in rando? Given our stance on previous fixes and trying to preserve the authentic experience, I think this falls in that line. The only concern I guess is hoping people turn it on 😅 Edit: |
That would be best.
It wouldn't be the first fix on a level like this to get made into a toggle. Isn't there a vanilla bug that can lock you out of an upgrade if the fix isn't enabled? |
|
Technically, it wasn't a bug until skip text was introdced. You would never be able to encounter it in vanilla without that functionality, at least as far as I know. I'd consider this exclusively fixing a bug we introduced with our own feature. |
|
Although, I could see an argument for not enabling it unless skip text is also enabled. I just don't see a reason to make it its own toggle. |
|
I think just extending the comment in code to explain that this doesn't happen with authentic text speeds/no skip text, but is needed because of skip text, provides enough context for the deviation from authentic code for people to know it shouldn't change authentic behavior. |
I made my comment above because this is replicate-able on n64 hardware by simply mashing A/B after turning in the Poacher's saw. Others in the Discord have also commented that this is a vanilla issue with text mashing. I just replicated it now via PJ64. And it can be replicated in SoH with skip text off & fast text off. 2023-08-04.08-53-39.mp4Fixing this is fixing a authentic vanilla bug that you can experience without any enhancements, similar to the Deku Nut upgrade fix (which has a toggle). |
|
Interesting. Why were they so inconsistent with their textboxes? I guess I'll have to make a fix toggle for it, but I still think it should be automatically enabled with text skip. |
…rdless of previous selection for the Fix toggle itself (so it works if you have the Fix toggle enabled, or if you have Skip Text enabled).
|
Fix toggle has been added. Skip Text forces the behavior. |
|
I'd be fine with having it as an "unfix" box. Regardless of skip text default to fixing it, but leave an option to restore the authentic behavior |
|
There is no authentic behavior when combined with skip text, though. If you don't have skip text on, then it's just a normal checkbox. I can't see why we'd want to have it able to be "unfixed" with our own enhancement enabled. If you enable the enhancement, you're already not worried about getting the authentic behavior. |
|
I'm just saying if this is a bug people can encounter without skip text I'm in favor of having it fixed by default regardless of skip text |
|
Ohhhh, I gotcha. We'll see what others have to say on the idea. |
|
We don't do that currently with similar bug fixes like the Deku Nut upgrade fix, which is arguably also something casual players can experience. I'm not completely against the fix being defaulted to on, but calling it an "unfix" feels weird to me, and it would be a precedence change. We could just throw it in the presets which is what we already do for the Deku Nut upgrade fix. |
|
Yeah, the presets seems the best option. Pretty much anything not default I'd say. |
|
I know we've had back and forth around how to handle authentic bugs before (I'm mostly thinking of the convo on #1752) I'd be happy to open the conversation around having bugs that default to fixed up again. I feel like providing the authentic experience (bugs and all) as an option is important, but doesn't need to be the default. |
|
I just realized it would be pointless to add the fix to the presets because of the way I force the behavior if Skip Text is on and Skip Text is in all the presets already XD |
Fixes #2200 - softlock when holding an item and skipping text giving the saw.
Build Artifacts