Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Align remaining unaligned assets for mac #3138

Merged

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Aug 21, 2023

This continues the fix done in #2819 to cover a few more left over spots that were still using unaligned string values.
This fixes a reported issue of some texture packs causing crashes on Macs with a M processor.

Fixes #3125

Build Artifacts

Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s no way we can programmatically find any additional remaining “unaligned assets” right?

@Archez
Copy link
Contributor Author

Archez commented Aug 26, 2023

There’s no way we can programmatically find any additional remaining “unaligned assets” right?

This could probably be found out programmatically. In this case though, there was only 8 instances of a __OTR__xxx string being assigned directly to a value, 3 are the ones I am fixing here. the other 5 are in authenticGfxPatches.cpp but those strings are not actually being passed into the renderer; instead they are just being used for the gfx patch lookup.

@garrettjoecox garrettjoecox merged commit 1d9adcd into HarbourMasters:develop Sep 10, 2023
@Archez Archez deleted the fix-mac-unaligned-assets branch December 17, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alternative assets loading issue on macOS
2 participants