Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweak] Update Rando save warning message for new file info screen #3163

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Aug 30, 2023

After the introduction of the "more file info" enhancement, the rando save warning message was overlapping it and hard to read if the enhancement was on.

This PR updates the rando save warning to now render beneath the main menu window with a textbox backdrop, so now it doesn't matter if the "more file info" enhancement is on or not. The message is still within the 4:3 ratio.

While updating, I also opted to switch to the newer Interface_DrawTextLine as it is less buggy than the older approach of using a dummy message context.

image

2023-08-30.01-18-33.mp4

Build Artifacts

@PurpleHato
Copy link
Member

Great stuff!
I noticed a tiny typo for French, "peuventêtre" should be "peuvent être" :)

@garrettjoecox garrettjoecox merged commit bba0a54 into HarbourMasters:develop Sep 10, 2023
@Archez Archez deleted the tweak-rando-save-warning branch September 10, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants