Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Strength Option #3302

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

inspectredc
Copy link
Contributor

@inspectredc inspectredc commented Oct 18, 2023

Allows the toggling of the strength upgrade from the pause menu. When toggled link will effectively take off the equipment and have no strength.

I made this because I think it's the best solution to a future issue that glitch logic may have and forcing this toggle option would allow for the glitch to be in logic.

I wasnt sure what the best method to convey this toggle-ability in the ui was but providing a video to help show (save file is vanilla in example)

StrengthToggle.mp4

Build Artifacts

@PurpleHato
Copy link
Member

PurpleHato commented Oct 19, 2023

Nice One!
Maybe you can do something similar as the Mask Selection option behind a cvar + glitched logic randomised settings and display the A icon when in those settings (so like that we're free of having one checkboxes in the menu)

It's just an idea, I don't really know if it's a good one :P

@inspectredc
Copy link
Contributor Author

Yea the plan is to have the toggling of any glitches which this aids to lock the setting to the seed, following the pattern with blue fire arrows.

I could add the "press A to equip" card to the bottom in the same way the other equipment works if thats what you mean?

@PurpleHato
Copy link
Member

PurpleHato commented Oct 19, 2023

I mean in the same manner we do it for the Mask selection and having hte A glyph just under the case; So it's a good visual appealing that means "this slot is different when in rando", and so like that you don't need to wait for the "Press A to equip"
image

@inspectredc
Copy link
Contributor Author

ah ok cool, ill have a look into that then!

@inspectredc
Copy link
Contributor Author

Added an A button icon now!

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@garrettjoecox garrettjoecox merged commit 1e4784a into HarbourMasters:develop Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants