Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS shuffle to the hell mode preset #3360

Merged

Conversation

Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Nov 6, 2023

@PurpleHato
Copy link
Member

PurpleHato commented Nov 6, 2023

As I remember the Hell mode preset was made to be on par with this one (reminder it was made a long time ago and some settings weren't there on SoH and might needs to be updated) https://wiki.ootrandomizer.com/index.php?title=Presets#Hell_Mode
Which doesn't include the MS Shuffle, I will let the other decides on that as it wouldbe missleading for those coming from OOTR

@inspectredc
Copy link
Contributor

As I remember the Hell mode preset was made to be on par with this one https://wiki.ootrandomizer.com/index.php?title=Presets#Hell_Mode Which doesn't include the MS Shuffle, I will let the other decides on that as it owuld be missleading for those coming from OOTR

was about to say the same thing, was wondering if there was any reason apart from making the seed more hellish that you wanted to add this to the preset?

@Pepe20129
Copy link
Contributor Author

Pepe20129 commented Nov 6, 2023

The description of the preset is All settings maxed but still using glitchless logic. Expect pain., if we're gonna leave it like it is to be on par with ootr we should at least change the description.
I think there should be a "maxed" preset that has every setting on and I thought it was the hell mode one.

@garrettjoecox
Copy link
Contributor

Yeah I created the hell mode preset, it wasn’t intended to have parity with zootr. I wouldn’t be opposed to adding a separate preset for that purpose but this one is just supposed to be maxed out settings.

@PurpleHato
Copy link
Member

The description of the preset is All settings maxed but still using glitchless logic. Expect pain., if we're gonna leave it like it is to be on par with ootr we should at least change the description. I think there should be a "maxed" preset that has every setting on and I thought it was the hell mode one.

Yup, I agree with that :)
I think it would be better to have the Hell mode matching OOTR and have a maxed preset for the ultra hardcore one

@PurpleHato
Copy link
Member

Yeah I created the hell mode preset, it wasn’t intended to have parity with zootr. I wouldn’t be opposed to adding a separate preset for that purpose but this one is just supposed to be maxed out settings.

Was it? I remember we were saying that since the beggining :o
My bad if I mistaken then

@Pepper0ni
Copy link
Contributor

As I remember the Hell mode preset was made to be on par with this one (reminder it was made a long time ago and some settings weren't there on SoH and might needs to be updated) https://wiki.ootrandomizer.com/index.php?title=Presets#Hell_Mode Which doesn't include the MS Shuffle, I will let the other decides on that as it wouldbe missleading for those coming from OOTR

This is because N64 doesn't have master sword shuffle as an option, at least not on stable.

Copy link
Member

@PurpleHato PurpleHato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard, after more exhange the Hell Mode was indeed maxed mode and I was mistaking it for the S6 Preset :)

@garrettjoecox garrettjoecox merged commit 1d3e7d4 into HarbourMasters:develop Nov 6, 2023
@Pepe20129 Pepe20129 deleted the ms_shuffle_in_hell_preset branch December 22, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants