Restore Original Scene Command Object List Behaviour (MacReady) #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
approved these changes
Jan 8, 2024
garrettjoecox
approved these changes
Jan 15, 2024
garrettjoecox
merged commit db02870
into
HarbourMasters:develop-macready
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3826 for MacReady
Original Description:
This restores the original behaviour of the scene command object list. What this achieves is restoring the behaviour of the Actor Glitch, which previously would not work on SoH.
I have included some extra comments explaining some things I learnt about when coming up with this.
See here for the relevant original behaviour from decomp https://github.com/zeldaret/oot/blob/c1a499c3ae7b0b6b54c66a651784d65c93a613e8/src/code/z_scene.c#L263C17-L263C17
I have tidied up the loops a bit since they are messy on decomp, and probably could be matched with for loops
Build Artifacts