Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: object unload using wrong index #3949

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix: object unload using wrong index #3949

merged 1 commit into from
Feb 20, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Feb 16, 2024 •
edited by github-actions bot
Loading

Accidentally was using i which is offset by play->objectCtx.unk_09 to bounds check cmdObj->objects, it should have been k instead.

Ooops 🙂

Fixes #3947

Build Artifacts

@Archez Archez changed the base branch from develop to develop-macready February 16, 2024 23:24
@Archez
Copy link
Contributor Author

Archez commented Feb 16, 2024

Needs to go to develop-macready actually.

garrettjoecox
garrettjoecox approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oldman-2673059788

@garrettjoecox garrettjoecox merged commit 19af448 into HarbourMasters:develop-macready Feb 20, 2024
8 checks passed
@Archez Archez deleted the fix-object-unload branch February 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Diving game Zora unloads when walking near
2 participants
@Archez @garrettjoecox