Fix endianess issue with camera setting data #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dev only issue or should this fix point to macready? |
It's an SoH always issue. Probably could target macready with this yea |
Archez
force-pushed
the
fix-camera-mode-data
branch
from
6fdf00c to
58ffb93
Compare
|
Updated the base. |
briaguya-ai
approved these changes
Feb 18, 2024
Kenix3
approved these changes
Feb 19, 2024
garrettjoecox
approved these changes
Feb 20, 2024
garrettjoecox
merged commit ef9fc0a
into
HarbourMasters:develop-macready
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera settings struct was using a union member and bitfield flags to pack a single 32bit int as multiple values. This assumes Big Endian (N64 hardware). On Little Endian systems, this led to
validModesbeing shifted by 2 bits causing some validation functions to behave incorrectly (couldn't C-Up in the fishing pond or bombchu bowling lobby).The other two single bit values are unused, so I've decided to just remove them and the bitfield flags so that
validModesis just treated as the full 32bit value. This fixes #1253.I've also confirmed this change works on Wii U (Big Endian).
Here is a print out of some of the values before and after, with the first person mode highlighted.
Before:
After:
Build Artifacts