-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved rando settings #3980
Improved rando settings #3980
Conversation
There was some unresolved brief discussion about the entrance tracker settings being useful in the window because you're more likely to be adjusting sorting/filtering on the fly mid-game, but I personally think it was a LOT to put in one window there. Just thought I'd bring it up though. |
You can also dock the settings window on top of the entrance tracker to adjust sorting/filtering on the fly
Maybe, but other settings windows (the item tracker one for example) have even more stuff so I think that if that's the case, we could revisit it in a future UI rework. |
Oh just to clarify, I was referring to having it all in one window (settings + tracker) being a lot. Originally there were just a couple options for sort order etc, but as the settings grew I think it makes more sense to finally split them into a separate window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval as it's not updated to current fixes, making it hard to test, and UI code isn't my area, but a quick scan and poke reveals no obvious issues. Will play with this more if it gets fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, now that I've done the modern menu on 2ship, it'll be brought here, too, and so that will probably be done differently anyway, but I see no reason not to have it in in the mean time.
Converts the settings for the entrance tracker into it's own window and changes the buttons that open the setting for the randomizer trackers into gear icons.
With help from @briaguya-ai for centering the icons
Build Artifacts