Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved rando settings #3980

Merged

Conversation

Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Feb 26, 2024

Converts the settings for the entrance tracker into it's own window and changes the buttons that open the setting for the randomizer trackers into gear icons.
307558706-f5c28054-4359-4075-8c90-f11962229c75

With help from @briaguya-ai for centering the icons

Build Artifacts

@Tawling
Copy link
Contributor

Tawling commented Feb 26, 2024

There was some unresolved brief discussion about the entrance tracker settings being useful in the window because you're more likely to be adjusting sorting/filtering on the fly mid-game, but I personally think it was a LOT to put in one window there. Just thought I'd bring it up though.

@Pepe20129
Copy link
Contributor Author

There was some unresolved brief discussion about the entrance tracker settings being useful in the window because you're more likely to be adjusting sorting/filtering on the fly mid-game,

You can also dock the settings window on top of the entrance tracker to adjust sorting/filtering on the fly

but I personally think it was a LOT to put in one window there. Just thought I'd bring it up though.

Maybe, but other settings windows (the item tracker one for example) have even more stuff so I think that if that's the case, we could revisit it in a future UI rework.

@Tawling
Copy link
Contributor

Tawling commented Feb 26, 2024

but I personally think it was a LOT to put in one window there. Just thought I'd bring it up though.

Maybe, but other settings windows (the item tracker one for example) have even more stuff so I think that if that's the case, we could revisit it in a future UI rework.

Oh just to clarify, I was referring to having it all in one window (settings + tracker) being a lot. Originally there were just a couple options for sort order etc, but as the settings grew I think it makes more sense to finally split them into a separate window.

Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval as it's not updated to current fixes, making it hard to test, and UI code isn't my area, but a quick scan and poke reveals no obvious issues. Will play with this more if it gets fixes.

soh/soh/SohMenuBar.cpp Show resolved Hide resolved
Copy link
Contributor

@Malkierian Malkierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, now that I've done the modern menu on 2ship, it'll be brought here, too, and so that will probably be done differently anyway, but I see no reason not to have it in in the mean time.

@Malkierian Malkierian merged commit f2958ae into HarbourMasters:develop-rando Jul 17, 2024
6 checks passed
@Pepe20129 Pepe20129 deleted the improved_rando_settings branch July 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants