Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rip out unused types #4041

Merged
merged 9 commits into from
Apr 7, 2024
Merged

rip out unused types #4041

merged 9 commits into from
Apr 7, 2024

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Apr 7, 2024 •
edited by github-actions bot
Loading

@briaguya-ai briaguya-ai added the do not merge Not ready or not valid changes label Apr 7, 2024
@briaguya-ai briaguya-ai mentioned this pull request Apr 7, 2024
Merged
@briaguya-ai briaguya-ai mentioned this pull request Apr 7, 2024
Closed
@briaguya-ai briaguya-ai mentioned this pull request Apr 7, 2024
Merged
@briaguya-ai briaguya-ai changed the title test ripping out unused types rip out unused types Apr 7, 2024
@briaguya-ai briaguya-ai marked this pull request as ready for review April 7, 2024 20:31
@briaguya-ai briaguya-ai removed the do not merge Not ready or not valid changes label Apr 7, 2024
Archez
Archez approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merge ready pending a OTR generation/play test.

@briaguya-ai briaguya-ai merged commit 897d3ef into HarbourMasters:develop Apr 7, 2024
8 checks passed
@briaguya-ai briaguya-ai deleted the test-rip-out-unused branch April 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briaguya-ai @Archez