Fix: add workaround for boost versions >=1.84.0 #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
May 1, 2024
garrettjoecox
approved these changes
May 1, 2024
KiritoDv
pushed a commit
to KiritoDv/Shipwright
that referenced
this pull request
May 6, 2024
briaguya-ai
pushed a commit
to briaguya-ai/Shipwright
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with boost 1.84.0 they switched around some internal types to using the std namespace instead of their own hacks.
Since our
_32methods are extensions on top of boost and use these internal types, we need a version check to control which types get used so that anyone building with a newer boost version does not run into errors.Build Artifacts