Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows build crash rainbow color issues #425

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix windows build crash rainbow color issues #425

merged 1 commit into from
Jun 2, 2022

Conversation

Baoulettes
Copy link
Contributor

sizeof issue make it crash on windows.
Thanks Melon :)

@Baoulettes
fix win build crash
d60ef0f 
sizeof issue make it crash on windows.
Thanks Melon :)
@jbodner09
Copy link
Contributor

Likely will close #424

@jbodner09 jbodner09 mentioned this pull request May 29, 2022
Merged
briaguya-ai
briaguya-ai approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working on my machine. note: this ifixes the issue on linux too

getbrainerror
getbrainerror approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@getbrainerror getbrainerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue #424 for me aswell.

@louist103
Copy link
Contributor

Tested it locally and it worked. The right way to do this would be to use a std::array and use the built in count but this is fine for now.

@louist103 louist103 merged commit 0bfe2fe into HarbourMasters:develop Jun 2, 2022
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 13, 2022
@Baoulettes @stratomaster64
fix win build crash (HarbourMasters#425)
07b5694 
sizeof issue make it crash on windows.
Thanks Melon :)
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 20, 2022
@Baoulettes @stratomaster64
fix win build crash (HarbourMasters#425)
09de5dd 
sizeof issue make it crash on windows.
Thanks Melon :)
@Baoulettes Baoulettes deleted the patch-2 branch July 6, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briaguya-ai briaguya-ai briaguya-ai approved these changes

@louist103 louist103 louist103 approved these changes

@getbrainerror getbrainerror getbrainerror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Baoulettes @jbodner09 @louist103 @getbrainerror @briaguya-ai