Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui window rework #4307

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

Malkierian
Copy link
Contributor

@Malkierian Malkierian commented Aug 24, 2024

This adapts SoH's GuiWindows to the new modern menu system of drawing. Currently excludes Check, Entrance and Item trackers, as well as the Input Viewer, with Draw() overrides to bypass the built-in ImGui Begin and End calls in the normal flow.

Build Artifacts

Malkierian and others added 2 commits August 22, 2024 20:52
…ent LUS except InputViewer, CheckTracker, ItemTracker and Modals.
…aw()` to bypass the ImGui Begin and End, as they're not intended to go in the modern menu.
@Malkierian
Copy link
Contributor Author

Oh, right, the modal system is also excluded.

Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Archez Archez merged commit b5037a0 into HarbourMasters:develop Sep 10, 2024
5 checks passed
@Malkierian Malkierian deleted the gui-window-rework branch September 10, 2024 19:47
ROGsamurai added a commit to ROGsamurai/Shipwright that referenced this pull request Sep 10, 2024
Arrenton added a commit to Arrenton/Shipwright that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants