Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop disabling dampe checkbox, as it's no longer forced to on for rando #4349

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Sep 17, 2024

If people complain about this too much we can do what we do for cutscenes and have the default value be IS_RANDO

Build Artifacts

@Malkierian
Copy link
Contributor

So with this, it just doesn't do anything automatically, including disabling the option?

@garrettjoecox
Copy link
Contributor Author

So with this, it just doesn't do anything automatically, including disabling the option?

Correct, it will behave similar to GoronPot above it, independent from whether you are in a rando file or not

Copy link
Contributor

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should probably default to on in rando mostly to prevent people being confused but it's not a big deal.

@Pepper0ni
Copy link
Contributor

We should probably be directing people to the rando enhancment preset more obviously, given that most rando QoL is an ehancment now, which would be more straightforward than seperate rando vs vanilla settings.

@Malkierian Malkierian merged commit 74c93b0 into HarbourMasters:develop-rando Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants