Remove UpdateHelpers, massivly speeding up Seed generation time #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pepe20129
reviewed
Sep 26, 2024
soh/soh/Enhancements/randomizer/3drando/location_access/locacc_castle_town.cpp
Outdated
Show resolved
Hide resolved
Pepper0ni
changed the title
Malkierian
approved these changes
Oct 2, 2024
Pepe20129
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateHelpers was running far, FAR too much and SCL exposed the issue, leading to the infamous seed generation times.
By removing it and directly calling functions to check real time instead, logic seed generation time on debug has been reduced by 90-95%, and reduced 80%+ on release. This PR mostly makes 1 to 1 swaps or easy to see unrolls to make resolving conflicts easier and reduce the chance of bugs. I did however fix a few obvious logic issues while I was there (logic thinking child can reflect nuts with hylian shield and some issues with gold scale.)
I also took the chance to clear a ton of unused stuff from the logic class, as if we go back to using helpers (which is in-theory faster, but would need changes to Time/Age handling to be realized) it will be in a very different structure.
Build Artifacts